dsmiley commented on PR #4997: URL: https://github.com/apache/solr/pull/4997#issuecomment-5983680841
I'm hesitant to merge this. It replaces an NPE with an error, but the null/race shouldn't have happened in the first place. We still have a TODO/problem to be resolved eventually. The fact that the collection is in a failed state is bad; this fixes that for this very narrow case. If you improved collection creation error detection to be graceful -- that would be welcome, and would also address the NPE here and also other bugs TBD. A colleague at my last company did that but didn't contribute it :-( -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
