jaykay12 commented on code in PR #5018: URL: https://github.com/apache/solr/pull/5018#discussion_r4179230461
########## solr/core/src/java/org/apache/solr/packagemanager/UserIO.java: ########## @@ -0,0 +1,35 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.solr.packagemanager; + +/** Console-facing output for package manager operations */ +@FunctionalInterface +public interface UserIO { Review Comment: That’s a fair point - it does look inverted. PackageManager still owns the operation flow today, so the print calls sit next to that logic. UserIO is only a sink so those calls don’t import org.apache.solr.cli: CLI passes ToolRuntime, and tests use NONE. I’d be happy to move the user-facing output into PackageTool and leave PackageManager as throw/return. That’s a larger split than this PR was aiming for; I was treating this change as just cutting the CLI dependency. Can I take that up in a follow-up PR, if that's okay to you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
