epugh commented on code in PR #5015:
URL: https://github.com/apache/solr/pull/5015#discussion_r4179600439
##########
solr/core/src/java/org/apache/solr/core/PluginInfo.java:
##########
@@ -208,16 +208,19 @@ public void writeMap(EntryWriter ew) throws IOException {
Map<String, Object> childrenGrouped = new LinkedHashMap<>();
for (PluginInfo child : children) {
- Object old = childrenGrouped.get(child.name);
+ // Group by type (not name): children are looked up by type via
getChildren(type),
+ // and unrelated plugin types may share a name (e.g. formatter/encoder
both named "html").
Review Comment:
Can we make it less verbose?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
