janhoy opened a new pull request, #5024:
URL: https://github.com/apache/solr/pull/5024
Two endpoints spelled the same URL twice in the generated OpenAPI document
by naming their path parameter differently per HTTP method:
/{indexType}/{indexName}/schema/dynamicfields/{fieldName} GET
/{indexType}/{indexName}/schema/dynamicfields/{dynamicFieldName}
DELETE, PUT
/cluster/filestore/files{path} DELETE
/cluster/filestore/files{filePath} GET,
PUT
The spec forbids this, and a consumer resolving a concrete URL picks one
entry and loses the verbs living in the other. Align the `@PathParam` names so
each collapses to a single entry carrying all of its operations.
Add a validateOpenApiSpec gradle task, wired into :solr:api:check, that
fails when two templates are identical after path-parameter-name erasure.
https://issues.apache.org/jira/browse/SOLR-18504
Bug found by Claude. Also fixed by Claude. So I'm merely a messenger here
:-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]