sarkaramrit1993 opened a new pull request, #5032: URL: https://github.com/apache/solr/pull/5032
https://issues.apache.org/jira/browse/SOLR-18031 `bin/solr post --filetypes xml example/exampledocs/*` posted every file. The shell expands `*` before the tool sees it, so the tool gets a list of files, and only directory walks checked `--filetypes`. The dry run summary was also wrong. The count was overwritten for each argument instead of added up, so it always said 1. Changes: - Files and globs now go through the same `--filetypes` check as directories. A skipped file gets a warning, which the ref guide already says should happen. - A glob that matches files, but none of the allowed types, now says so instead of claiming nothing matched. - With `--type` set, all files are still posted like before. - The count now sums across arguments. Not changed: with `--type` set, directories are still filtered by `--filetypes` but explicit files aren't. That was already the case, and changing it would break the documented `--type text/csv data.tsv` example. Happy to open a separate issue if that's worth looking at. Tests: two new cases in PostToolTest (explicit files, and globs; the glob test is skipped on Windows since `*` isn't a valid path character there). Ran the cli tests, SolrCloudExampleTest, and the post, help, auth, extraction, SSL and rolling upgrade BATS tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
