Jan Høydahl created SOLR-18513:
----------------------------------

             Summary: Port ExportTool to PicoCli
                 Key: SOLR-18513
                 URL: https://issues.apache.org/jira/browse/SOLR-18513
             Project: Solr
          Issue Type: Improvement
          Components: cli
            Reporter: Jan Høydahl


Port {{ExportTool}} to picocli, adding the picocli code path alongside the 
existing commons-cli one.

*Covers:* {{bin/solr export}}

The command exports documents from the collection named by {{\-c}} / 
{{\-\-name}} to a local file, with {{\-\-query}}, {{\-\-fields}}, 
{{\-\-limit}}, {{\-\-output}}, {{\-\-compress}} and {{\-\-format}} ({{json}}, 
{{jsonl}} or {{javabin}}, defaulting to {{json}}). There are no sub-commands.

As with {{config}}, {{\-\-format}} is a good candidate for a picocli enum.

*Acceptance criteria*
* {{bin/solr export}} and all its options work with {{SOLR_PICOCLI=true}}, and 
the commons-cli path is left behaviourally unchanged.
* {{ExportTool}} is registered in {{SolrCLI}}'s picocli {{subcommands}} list 
and {{ToolBase.callTool()}} is implemented, replacing the 
{{UnsupportedOperationException}} stub.
* Shared options reuse the existing mixins ({{ConnectionOptions}}, 
{{CredentialsOptions}}, {{HelpMixin}}) rather than redeclaring them.
* An {{ExportToolPicocliTest}} subclasses the existing test and overrides only 
the {{runTool}} hook, so the inherited assertions run through both parsers.
* {{./gradlew :solr:solr-ref-guide:generateCliDocs}} is re-run and the 
generated {{cli/solr-export.adoc}} page is committed, so 
{{checkCliDocsUpToDate}} passes.

*AI assistance:* a coding-agent prompt template encoding the patterns already 
established by the ported tools is available at 
[https://gist.github.com/janhoy/a3fe0dbcaadf24b3493558946cc549d9] — name 
{{ExportTool}} in its Assignment line up front and the rest of the prompt 
adapts. Please review agent output as carefully as hand-written code.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to