janhoy commented on PR #4931: URL: https://github.com/apache/solr/pull/4931#issuecomment-6018083871
@serhiy-bzhezytskyy this got closed unintentionally after merging the feature-branch PR. I expected GH to auto move this PR tonto main as it usually does, but no. Please try to edit target branch yourself on this PR, if you can't do it I'm afraid you'll have to open a new PR. Also FYI, each remaining tool or group of tools that are not yet ported now have separate JIRA issues, see https://issues.apache.org/jira/issues/?jql=project%20%3D%20SOLR%20AND%20text%20~%20%22port%20picocli%22 Ideally there will be one PR per JIRA/Tool for easier review. This huge PR adds 1317 lines of code and what will happen is that it wil be hard to get reviewers for it. Also, I made a LLM prompt to capture some best practices from other ports, see link in each JIRA. Feel free to ask your LLM to consider that info - perhaps there are useful improvements to be found. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
