adityamparikh opened a new pull request, #249:
URL: https://github.com/apache/solr-mcp/pull/249
## What
Fixes
`IndexingServiceTest.indexMarkdownDocuments_IndexesEachElementAsItsOwnDocument`,
which fails on `main`. The test now stubs and captures the single
`UpdateRequest` sent through `solrClient.request(...)`, the same pattern the
other indexing tests use, and asserts that request carries both Markdown
documents.
## Why
#207 added the test while indexing still called `solrClient.add(collection,
docs)`. #233 changed indexing to send one `UpdateRequest` per call. The two
merged without a textual conflict, so the test now verifies an `add(...)` call
that never happens:
```
IndexingServiceTest >
indexMarkdownDocuments_IndexesEachElementAsItsOwnDocument() FAILED
org.mockito.exceptions.verification.WantedButNotInvoked at
IndexingServiceTest.java:334
```
Because `integrationTest` is finalized by `jacocoTestReport`, which depends
on `test`, this failure also turns the `Integration Tests` job and every Solr
compatibility job red on every PR.
## Verification
- `./gradlew test --tests '*IndexingServiceTest'` on `main`: 24 tests, 1
failure.
- `./gradlew build -x rat` with this change: 464 tests, 0 failures, 0
skipped.
`-x rat` skips the root `solr-mcp-ip-clearance.xml`, which has no license
header on `main`. That is unrelated to this change.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
