adityamparikh opened a new pull request, #252: URL: https://github.com/apache/solr-mcp/pull/252
## Summary A successful tool call logged nothing, so a trace's **Logs for this span** link in Grafana was empty for every normal request. This adds one INFO line when `search` succeeds: ``` INFO ... [<trace-id>-<span-id>] o.a.s.mcp.server.search.SearchService : Search on collection films matched 1100 documents ``` - **Where:** in `SearchService.search`, inside the `@Observed` method, so the line carries the `search-service#search` span's ID rather than a parent span's. - **What:** the collection and `numFound`, which the span does not record. The query string is left out because it can carry user data. - **Docs:** `docs/observability.md` and its site copy said successful tool calls never log; updated to say `search` does. This replaces #236, which added a framework-level `ObservationHandler` to log every tool call's name and duration. The span already records both. ## Test plan - [x] `./gradlew build -x rat`: 464 tests, 0 failures, 0 skipped. (`:rat` fails on `main` on `solr-mcp-ip-clearance.xml`, unrelated.) - [x] Ran the jar with `PROFILES=http` against local Solr and `grafana/otel-lgtm`, called `search` on `films`: the line above was logged, and Tempo shows its span ID (`c507655db6b0f332`) is the `search-service#search` span of that trace. 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
