epugh opened a new pull request, #5057: URL: https://github.com/apache/solr/pull/5057
https://issues.apache.org/jira/browse/SOLR-16640 # Description doQuery() assumed every response was a SQL result-set and crashed with an uncaught TypeError ("Cannot read properties of undefined (reading 'docs')") whenever it wasn't - e.g. when the sql module/handler isn't installed, which returns a 404 JSON body with no "result-set" key. The UI was then left showing a blank grid with no explanation. # Solution Wrapped the response handling (shared between the success and error callbacks, since app.js's doNotIntercept interceptor quirk routes most failures through the success callback too - same root cause as SOLR-9759) to fall back to showing the raw message via the existing sqlError display instead of crashing. # Tests manual happy path: <img width="870" height="748" alt="image" src="https://github.com/user-attachments/assets/2a331a95-259e-405c-8d29-9cb40684c6ea"; /> sad path: <img width="911" height="774" alt="image" src="https://github.com/user-attachments/assets/78fe4641-2bc0-43cc-bf95-ea02718f87cb"; /> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
