jaykay12 commented on code in PR #5018: URL: https://github.com/apache/solr/pull/5018#discussion_r4231377057
########## solr/core/src/java/org/apache/solr/cli/ZkMkrootTool.java: ########## @@ -16,7 +16,7 @@ */ package org.apache.solr.cli; -import static org.apache.solr.packagemanager.PackageUtils.format; +import static org.apache.solr.cli.packagemanager.PackageUtils.format; Review Comment: Agreed - format/formatGreen aren’t package-manager-specific; ZK tools using them is making it clearer. Will that be okay if i take this up in some follow-up PR? will get this refactoring done & move these to CLIUtils which looks to be better place. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
