epugh commented on PR #5094: URL: https://github.com/apache/solr/pull/5094#issuecomment-6126586007
Posted an independent vetting pass on this PR (reproduced the bug on `main`, confirmed the fix on this branch, traced the fix through to the originally-reported Schema Designer crash path): https://claude.ai/code/artifact/e5aa97fa-a8e5-476b-9897-b969602f3af4 Verdict: approve, with one note — worth explicitly calling out in the description why this takes a different approach than the `return null` suggested earlier in the JIRA thread. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
