janhoy opened a new issue, #101:
URL: https://github.com/apache/solr-orbit/issues/101
Passing `--test-iterations=1` explicitly runs no benchmark at all, prints `✅
SUCCESS`, and exits 0.
Reproduce against any running Solr:
```
$ solr-orbit run --pipeline=benchmark-only --target-hosts=127.0.0.1:8983 \
--workload=nyc_taxis --test-iterations=1 --test-mode
[INFO] Please enter a valid number of test iterations
[INFO] ✅ SUCCESS (took 0 seconds)
$ echo $?
0
```
Omitting the flag works correctly, so this only hits callers that pass it —
which automation tends to do. The exit code and the `SUCCESS` banner make it
look like a benchmark ran.
**Expected:** `--test-iterations=1` behaves exactly like omitting it.
**Cause:** `benchmark.py:1253` computes `iterations =
int(args.test_iterations)` and branches on `iterations > 1`, but the single-run
branch tests `args.test_iterations == 1` — the raw argparse value. The argument
has `default=1` and no `type=`, so it is the integer `1` when defaulted and the
string `"1"` when passed. `"1" == 1` is false, so it falls through to the
`else`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
