sarkaramrit1993 commented on PR #5127: URL: https://github.com/apache/solr/pull/5127#issuecomment-6202610597
Took a look, it needed two small read-only accessors. Sub-command ids are `rebalanceleaders_<core>_<nanoTime>`, so the test can't guess them and ask REQUESTSTATUS. It needs a way to list what the tracker holds. Pushed in 52b28342fde: - `DistributedApiAsyncTracker.getTrackedAsyncIds()` returns `trackedAsyncTasks.keys()` - `DistributedCollectionConfigSetCommandRunner.getTrackedAsyncIds()` passes it through, reached via `ZkController.getDistributedCommandRunner()` Both `@VisibleForTesting`, no behavior change. The test now snapshots the async ids before the call and diffs after in both modes, so the disabled-Overseer branch gets a direct leak check too. Checked it fails when the wait ends without deleting the ids (lists the 6 leftover `rebalanceleaders_*` ids), and passes in both modes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
