janhoy opened a new pull request, #120: URL: https://github.com/apache/solr-orbit/pull/120
Compose v1's standalone `docker-compose` binary was hardcoded in both launchers and in the `it/` prerequisite check. It is end of life and absent from current CI images, so the compose launcher path could not run there and every integration test errored in `setup_module`. `solrorbit/utils/docker.compose_command()` probes for `docker compose`, falls back to `docker-compose`, caches the answer, and raises an explanatory `SystemSetupError` when neither is present. Verified by reproducing the CI environment locally — a `PATH` with Compose v2 but no `docker-compose` binary. Before: `FileNotFoundError: [Errno 2] No such file or directory: 'docker-compose'`, the exact CI failure. After: the command resolves to `docker compose`, `check_prerequisites()` passes, and `it/info_test.py it/list_test.py it/download_test.py it/proxy_test.py` give 13 passed. The full unit suite is 1163 passed / 5 skipped both normally and under that simulated environment, and the no-Compose-at-all path produces the intended setup error. The existing launcher tests asserted the literal v1 string and would otherwise have started shelling out to real Docker; they now pin the flavour, which also makes them independent of what is installed on the machine running them. Fixes #119 🤖 Assisted by Claude Code -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
