janhoy opened a new pull request, #121: URL: https://github.com/apache/solr-orbit/pull/121
Follow-up to #120, which introduced the regression. The integration workflow passes its version-override input through as `IT_DISTRIBUTIONS` whether or not it was filled in. With the input left at its default the variable is present and empty rather than absent, and `os.environ.get`'s default only applies when the key is missing — so `DISTRIBUTIONS` became `[]`. `test_docker_distribution` and `tracker_test`'s fixture index into that list and failed with `IndexError`. `test_tar_distributions` is the worse case: it loops over the list, so an empty one made it pass having tested nothing. Reads the variable with `or` so an empty value falls back to the default, and refuses to import when the result is still empty — a vacuous pass is the one outcome this suite must never produce. Verified for each case: unset, empty, an explicit override, and a value of only separators (which now raises instead of emptying the list). Seen on https://github.com/apache/solr-orbit/actions/runs/38916978027, where the rest of the suite reached 15 passed in 10m09s, `sources_test` included. 🤖 Assisted by Claude Code -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
