janhoy commented on code in PR #21: URL: https://github.com/apache/solr-orbit-workloads/pull/21#discussion_r4293683240
########## nyc_taxis/README.md: ########## @@ -95,7 +95,12 @@ parameters. ## Search operations The following named operations are defined in `operations/default.json` and used by the test -procedures above: +procedures above. In the notes, *upstream* means OpenSearch Benchmark's `nyc_taxis` +([opensearch-benchmark-workloads](https://github.com/opensearch-project/opensearch-benchmark-workloads/tree/main/nyc_taxis)), +which these operations were ported from. Elastic's `rally-tracks` carries a workload of the same +name but with different values in places — `fixed_interval: 10d` and `calendar_interval: week` +where OpenSearch Benchmark has `60d` and `month` — so the two are not interchangeable as a +reference. Review Comment: No need to describe what opensearch does here. Less comments is better, less reference to some now independent project is better. Instead describe objectively why we do this change. Also no need for the super long "Notes" below, keep it factual as if Solr Orbit stands on its own feet. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
