syahra712 opened a new pull request, #135: URL: https://github.com/apache/solr-orbit/pull/135
### Description `cluster-environment-info` is listed by `solr-orbit list telemetry` and documented, but `WorkerCoordinator._create_solr_telemetry_devices` never created a `ClusterEnvironmentInfo`, so `--telemetry cluster-environment-info` recorded nothing. This PR adds the device to the list that `_create_solr_telemetry_devices` returns, using the same `SolrClient` and metrics store as the other REST devices. `ClusterEnvironmentInfo` is not internal, so `Telemetry` still only runs it when it is requested with `--telemetry`. ### Issues Resolved Fixes #134 (found while looking into #5) ### Testing - [x] New functionality includes testing - `tests/worker_coordinator/worker_coordinator_test.py::WorkerCoordinatorTests::test_creates_cluster_environment_info_device` calls `_create_solr_telemetry_devices` with a `SolrClient` mock. It checks that exactly one `ClusterEnvironmentInfo` is created and that it uses that client. On `main` it fails (`1 != 0`). - The full `tests/` suite passes locally on Python 3.12 (1175 passed, 5 skipped), and `ruff check .` passes. I haven't run the integration suite (`it/`). --- By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
