dsmiley commented on code in PR #5178:
URL: https://github.com/apache/solr/pull/5178#discussion_r4304708464
##########
solr/api/src/java/org/apache/solr/client/api/util/Constants.java:
##########
@@ -24,8 +24,18 @@ private Constants() {
public static final String INDEX_TYPE_PATH_PARAMETER = "indexType";
public static final String INDEX_NAME_PATH_PARAMETER = "indexName";
+
+ // "c" is accepted alongside "collections" because Solr internally forwards
a v2 request to the
+ // node actually hosting a collection using the short "/c/{collection}/..."
alias (see
+ // HttpSolrCall#sendRemoteProxy and V2HttpCall's "c"/"collections"
handling); without it, any
+ // JAX-RS resource built on this prefix 404s with "Cannot find API for the
path" whenever the
+ // request has to be proxied to another node.
Review Comment:
I wonder do we really need this justification. It doesn't look strange for
'c' to be here (to me); I'm not going to wonder what would break if one of
these items was missing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
