nick-boss-tech commented on code in PR #5180:
URL: https://github.com/apache/solr/pull/5180#discussion_r4309812176
##########
solr/solr-ref-guide/build.gradle:
##########
@@ -487,6 +487,8 @@ task checkSiteLinks(type: NpxTask) {
"--debug",
// Ignore the java docs url in the header, since it is an absolute path
"--url-ignore",
"${project(':solr:documentation').docroot.toPath()}/index\\.html",
+ // Changes.html is generated by release tooling, not by the local
documentation build.
+ "--url-ignore",
"${project(':solr:documentation').docroot.toPath()}/changes/Changes\\.html",
Review Comment:
No. file:/ only matches absolute file URLs. The Changes link is relative in
a local build. I changed the ignore to changes/+Changes\.html, which covers the
single- and double-slash forms. checkSiteLinks fails without it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
