punAhuja commented on code in PR #5172:
URL: https://github.com/apache/solr/pull/5172#discussion_r4311220036
##########
solr/core/src/test/org/apache/solr/handler/component/CombinedQueryComponentTest.java:
##########
@@ -196,7 +224,8 @@ public void testCombinerPlugin() throws Exception {
+ "\"fields\":[\"id\",\"score\",\"title\"],"
+
"\"params\":{\"combiner\":true,\"combiner.algorithm\":test,\"combiner.query\""
+
":[\"lexical1\",\"lexical2\"],\"debug\":[\"results\"]}}"));
- assertEquals(10, rsp.getResults().getNumFound());
+ // the test combiner fuses to an empty list, so numFound reflects the
fused result
+ assertEquals(0, rsp.getResults().getNumFound());
Review Comment:
Addressed, the empty fused pool now falls back to the largest sub-query's
match count.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
