[
https://issues.apache.org/jira/browse/SOLR-18188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18131411#comment-18131411
]
Sanjay Dutt commented on SOLR-18188:
------------------------------------
Little late to the party, but flaky tests are having fun as always. I spent
some time investigating this and came across this thread; Hoss and David are
already on it. Thanks to fucit for the detailed per-test data; Develocity has
some of it but is missing September.
If anyone's in the mood for some light reading on flakiness, the full write-up
is here :
https://iamsanjay.github.io/solr-notes/RecoveryAfterSoftCommitTest.html
SOLR-18401 already reduced the failures a lot (from ~8% to ~2% on Jenkins).
What's left are requests that were already sent (committed) when the connection
failed, which the client correctly won't replay.
RecoveryAfterSoftCommitTest is meant to test full recovery after a replica is
cut off, so the adds during the cut don't need to go to that replica. Creating
a \{{CloudSolrClient}} with \{{shardLeadersOnly=true}} for the adds after the
proxy cut, as #5098 does, keeps them away from the cut replica. In 100 runs on
Linux with any-replica routing forced, that took failures from 16 to 0, and
recovery still ran every time.
> solr-test-framework: Remove Apache HttpClient usages
> ----------------------------------------------------
>
> Key: SOLR-18188
> URL: https://issues.apache.org/jira/browse/SOLR-18188
> Project: Solr
> Issue Type: Task
> Components: test-framework, Tests
> Reporter: David Smiley
> Assignee: David Smiley
> Priority: Major
> Labels: pull-request-available
> Fix For: 10.1
>
> Time Spent: 7h 10m
> Remaining Estimate: 0h
>
> As of this writing, the last usages of Apache HttpClient are in Solr's tests.
> This issue aims to remove it completely. But it's a lot of work.
> Some possible steps:
> * Remove tests for our HttpSolrClient & friends (fundamentally based on
> Apache HttpClient)
> * Replace usages of HttpSolrClient.getHttpClient with
> HttpJettySolrClient.getHttpClient
> * Replace usages of HttpSolrClient.getBaseURL by introducing a new base
> client that has this method. Or access similarly from Jetty when easily
> available.
> * of course, stop using HttpSolrClient & friends. Maybe class-by-class.
--
This message was sent by Atlassian Jira
(v10.3.26#10030026)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
