nick-boss-tech commented on PR #5167: URL: https://github.com/apache/solr/pull/5167#issuecomment-6390058573
**The lock-release fix looks sound; one P3 rationale/test issue found.** The cleanup comment says an existing running marker would make retries fail with NodeExistsException. However, DistributedMap.put uses overwrite-on-exists behavior, so a successful retry can proceed without deleting that marker. The test proves lock availability and checks that remove was called, but does not establish the claimed retry failure. Correct the rationale and, if retaining cleanup as retry recovery, test a write that succeeds before timing out followed by successful task execution. AI-generated static review. Thanks for submitting this! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
