nick-boss-tech commented on PR #5173: URL: https://github.com/apache/solr/pull/5173#issuecomment-6390174815
Thanks for submitting this! **Quick Review (static, AI-generated):** The three portable tests mentioned on JIRA need no new permission and could be adopted now. They are still absent from the PR. Three things deserve follow-up: 1. Add portable error-contract coverage. Inject NoSuchFileException and FileNotFoundException and expect false; inject an unexpected IOException and verify it propagates without calling openInput. This fits the existing policy. 2. Correct the mmap probe’s final measurement. It measures the selected .si file while the reader is open, then checks hardcoded _0.si after closing it. Those may be different files, so the final zero does not reliably prove release of the measured mappings. Keep the same filename throughout. This affects that diagnostic claim, not the separate portable regression tests. [Probe](https://gist.github.com/nick-boss-tech/bbdb73c27f36e060dd31af0cacb951ef) 3. Narrow the NIOFS benchmark conclusion. Your query results support retaining MMap for searching. They do not resolve whether a separate, replication-only NIOFS handle would help. That copy-only use is what [Lucene’s linked recommendation](https://github.com/apache/lucene/issues/15054#issuecomment-3184410243) discusses. Keep that investigation separate from this fix. For an eventual in-suite mmap measurement, consider a narrow read-only grant for /proc/self/maps with Linux/JDK guards. There is no need to make that a prerequisite for the portable tests. The Javadoc issue was already raised and remains open. The PR title and ticket link are corrected; the commit-message ticket typo remains. Current-head CI is green, but it does not include my proposed tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
