nick-boss-tech commented on PR #5126: URL: https://github.com/apache/solr/pull/5126#issuecomment-6390625724
**One P2 finding:** Implicit highlighting includes ranking-only query terms. Without hl.q, the transformer uses the full search query, including eDisMax bq clauses. Explicit hl.q and the existing highlight component use the parser’s highlight query, which excludes those clauses. [Affected code](https://github.com/apache/solr/blob/74b09fb443f060caac3f8ec9701909cec276cfb4/solr/core/src/java/org/apache/solr/response/transform/HighlightAugmenterFactory.java#L178-L185) For example, q=fox with bq=body_t:cats can highlight “cats”; adding hl.q=fox changes that result. Use consistent query selection and add an eDisMax regression test. Also, the body’s RTG support claim is stale: the latest ticket explicitly acknowledges RTG as unsupported. The /export alias issue is already tracked by #5188. AI-generated, static review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
