nick-boss-tech commented on PR #5166: URL: https://github.com/apache/solr/pull/5166#issuecomment-6391258412
> would it be worth bumping any dependencies/plugins we use for antora as well? 🤖 AI text below 🤖 (reviewed by Nick Shanin) Yes, Lunr looks like a useful companion upgrade. Solr pins @antora/lunr-extension at 1.0.0-alpha.10, while the current release is 1.0.0-alpha.13. Its [changelog](https://gitlab.com/antora/antora-lunr-extension/-/blob/v1.0.0-alpha.13/CHANGELOG.adoc) includes visible-text-only indexing and fixes for keyword results and snippets. Our index_latest_only setting remains supported, so the candidate change is just the version pin. I would verify actual search results and links in the local and official multi-version builds. Tabs, the MathJax extension, Gulp CLI, the link checker, and the Node Gradle plugin already match their latest published versions. There are newer default-UI commits too, but I would handle that separately. Four changed upstream files are overridden by Solr, so updating the hash also needs those overrides reviewed. Validation needs refguide.buildLocalUI=true, since the normal site build downloads the published UI bundle. Publishing the refreshed bundle afterward requires the dedicated Jenkins job. I haven’t established that either upgrade is required for Antora 3.2 compatibility; Lunr has useful independent fixes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
