dsmiley opened a new pull request, #5228: URL: https://github.com/apache/solr/pull/5228
🤖 `test_rolling_upgrade.bats` was upgrading between stale, hardcoded nightly snapshot images (9.10 → 10.0). Docker Hub stopped rebuilding them months ago, and they have nothing to do with the code under test. The smoke tester also never tested the RC's Docker image. **Rolling upgrade test** - The starting image defaults to the official `solr:<previous major>-slim`, i.e. the latest release of the previous major. On `main` that's `solr:10-slim`. - The target image defaults to `apache/solr:<version>`, the tag `./gradlew dockerTag` applies. The test doesn't build images; it skips if the image is missing. `SOLR_BEGIN_IMAGE` / `SOLR_END_IMAGE` still override. - Uses `SOLR_MODE=solrcloud` instead of `-c`, which Solr 10+ rejects. - Drops `--platform linux/amd64`, so locally built (native arch) images work. **Smoke tester** - When a Docker daemon is available, it builds `apache/solr:<version>` from the RC's binary `solr-<version>.tgz` before `integrationTest`, so this test runs against the RC. Without Docker, it prints a warning and the Docker-based tests skip. **Release wizard** (formerly #5227) - The RM's smoke tester step and the `[VOTE]` email now recommend running a Docker daemon before starting the smoke tester. **Testing:** I built `solr-11.0.0.tgz`, built the image from it exactly as the smoke tester does, and ran the test: it passed, upgrading `solr:10-slim` → 11.0.0. Without the image, the test skips with a hint to run `dockerTag`. `gradlew check -x test` passes. **Notes** - After a skip, building the image and re-running needs `--rerun`, because Gradle doesn't track the Docker image as an input of `integrationTests`. - If your Gradle cache has jars with mode `600`, a locally built dist and image get them too, and Solr in the container fails with `NoClassDefFoundError`. I'll follow up with a separate PR to normalize dist file permissions. No changelog entry: this only changes tests and release tooling. 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
