nick-boss-tech commented on PR #5224: URL: https://github.com/apache/solr/pull/5224#issuecomment-6406025094
Hi @mkhludnev, 🤖 AI text below 🤖 (reviewed by Nick Shanin) The current helper closes its DirectoryReader before callers consume the returned iterator. I changed it to borrow a LeafReaderContext; each test now owns its reader and keeps it open through all iterator assertions. Only TestScriptFilterIntervalsSource.java changes. Production code and the existing assertions are unchanged. I did not rerun the parent helper or demonstrate a failing-before case. I recommend including this small change so the tests use reader-backed postings only while the reader is open. Would you be comfortable incorporating it here? [Test-only diff through 72a0daacd374](https://github.com/nick-boss-tech/solr/compare/f28c6e79c82a9fb74c3e07607b86e74b3d4331d0...72a0daacd37478f3954272f4fa55511703af4b78) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
