kotman12 commented on code in PR #5188:
URL: https://github.com/apache/solr/pull/5188#discussion_r4378290915


##########
solr/core/src/java/org/apache/solr/search/ReturnFields.java:
##########
@@ -104,6 +104,20 @@ public Set<String> getNonScoreDependentReturnFieldNames() {
    */
   public abstract boolean wantsField(String name);
 
+  /**
+   * Returns <code>true</code> if the value of the specified index field is 
needed, either to return
+   * or for use by transformers. This is <code>false</code> for a field that 
only shares its name
+   * with a pseudo field (e.g. an alias or a transformer), unless 
<code>*</code> was requested.
+   */
+  public abstract boolean wantsLuceneField(String field);

Review Comment:
   `loadsField` is fine, I suppose it is implied if it is getting "loaded" that 
it is from somewhere, i.e. the index. I agree that `returnsField` is much 
better.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to