janhoy commented on code in PR #5063: URL: https://github.com/apache/solr/pull/5063#discussion_r4380801127
########## solr/core/src/java/org/apache/solr/cli/PackageTargetOptions.java: ########## @@ -0,0 +1,46 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.solr.cli; + +import picocli.CommandLine; + +/** Where a package (un)deploy applies: cluster-level plugins or the given collections. */ +public class PackageTargetOptions { + @CommandLine.Option( + names = {"--cluster"}, + description = "Specifies that this action should affect cluster-level plugins only.") + public boolean cluster; + + @CommandLine.Option( + names = {"--collections"}, + paramLabel = "COLLECTIONS", + description = + "Specifies that this action should affect plugins for the given collections only, excluding cluster level plugins.") + public String collections; + + /** The error to print when neither target was given, or null if one was. */ + String missingTargetMessage(String verb) { Review Comment: Good point — the either-or check had no direct coverage: `PackageToolPicocliTest` only re-runs `PackageToolTest` through picocli, and `testDeployValidationMessages` always passes `--collections`, so the "neither given" path was never exercised. Added `PackageTargetOptionsTest`, a parsing-level test in the same style as `ConnectionOptionsTest` covering `--cluster`, `--collections`, both, and neither (checking the message names the right verb for deploy vs undeploy). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
