Copilot commented on code in PR #143:
URL: https://github.com/apache/solr-orbit/pull/143#discussion_r4382338441
##########
solrorbit/test_run_orchestrator.py:
##########
@@ -462,6 +462,25 @@ def _load_cluster_config(cfg):
return instance
+def _create_jvm_telemetry_devices(cfg):
+ """
+ Build the JVM telemetry devices (``jfr``, ``gc``, ``jit``) enabled with
``--telemetry``.
+
+ ``SolrProvisioner`` adds the ``instrument_java_opts()`` of every device it
is given to
+ ``SOLR_OPTS``, so only the enabled ones are returned. Their output goes to
a
+ ``telemetry`` directory inside the test run directory.
+ """
+ enabled_devices = cfg.opts("telemetry", "devices", mandatory=False,
default_value=[]) or []
+ telemetry_params = cfg.opts("telemetry", "params", mandatory=False,
default_value={}) or {}
+ log_root = os.path.join(paths.test_run_root(cfg), "telemetry")
+ devices = [
+ telemetry.FlightRecorder(telemetry_params, log_root,
java_major_version=None),
+ telemetry.Gc(telemetry_params, log_root, java_major_version=None),
+ telemetry.JitCompiler(log_root, telemetry_params),
Review Comment:
Enabling `--telemetry jit` now prevents Solr from starting on supported
modern JDKs: `JitCompiler.instrument_java_opts()` still emits
`-XX:+TraceClassLoading`, which the JVM rejects with `Unrecognized VM option
'TraceClassLoading'`. Both provisioned pipelines now pass that flag through to
the JVM. Remove the obsolete option or replace it with `-Xlog:class+load=info`
in `JitCompiler` before wiring it in, and add a regression assertion that the
obsolete flag is absent.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
