nick-boss-tech commented on PR #5241: URL: https://github.com/apache/solr/pull/5241#issuecomment-6435404327
🤖 *AI text below* 🤖 *(reviewed by Nick Shanin)* @epugh, I found an error-handling regression in the core overview after this migration. Its replication callback treats every failure as "Replication is not configured", but the generated client bypasses Angular's HTTP interceptor. A replication-specific 403 loses the permission warning, a server error loses its actual message, and a 401 can miss the login redirect. I prepared a small fix on top of your current head (`aa8272ef089c`): inject and call the existing `ApiErrorHandler`, as the dedicated Replication controller already does. The new browser tests fail only the replication HTTP request while the other overview reads succeed, then assert the permission banner, server message, or login form. The 401 case also checks stale-header removal and the saved return location. [Diff with the fix and regression tests](https://github.com/nick-boss-tech/solr/compare/aa8272ef089c39df449c519551ef439557b876f8...3b36f32e93d513c58ff14c48db303a296218f84a). Linux verification at `3b36f32e93d513c58ff14c48db303a296218f84a`, JDK 21 and Chrome/chromedriver 156, seed `5241C0DE`: - `AdminUiCoreOverviewErrorsTest`: 3 tests passed, zero failures, errors, or skips. - The two Core Admin classes, two Replication classes, and `AdminUiSecurityAuthTest`: 10 tests passed across 5 classes, zero failures, errors, or skips. - Tidy left a clean tree; forbidden-API, JavaScript syntax, and whitespace checks passed. Root `check -x test` passed with `NODE_ENV` unset in a standalone clone at the same SHA. Its earlier git-worktree attempt failed because Antora rejected that checkout layout; the standalone-clone run completed successfully. Browser runs used an explicit chromedriver path on the ARM64 host. On your original production code (`aa8272ef089c`) with only the new test file added, all three tests fail at their intended UI checks, after successful initial reads and confirmation of the injected 403, 503, or 401 response. [Linux verification details](https://github.com/nick-boss-tech/solr/blob/5736254fa050881d1e2d70638ccc54fd6a21042c/receipts/PR-5241-overview-errors.md), [log and assertion excerpts](https://github.com/nick-boss-tech/solr/blob/5736254fa050881d1e2d70638ccc54fd6a21042c/reports/pr-5241-round-2-evidence-closeout-vm4.md). To take the tested follow-up commits: ```sh git switch SOLR-16398-admin-ui-replication-details-v2 git fetch https://github.com/nick-boss-tech/solr.git solr-16398-submit git merge --ff-only 3b36f32e93d513c58ff14c48db303a296218f84a ``` You're welcome to take these commits or adapt the changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
