dajiaohuang opened a new pull request, #5243: URL: https://github.com/apache/solr/pull/5243
# Description Fixes [SOLR-18492](https://issues.apache.org/jira/browse/SOLR-18492): preserve `HttpSolrCall.Action.RETRY` in the V2 request path so a stale-cluster-state retry is not silently treated as `ADMIN`. # Solution Return immediately from `V2HttpCall` when the handler action is `RETRY`, matching the V1 servlet dispatch behavior. Add a regression test that exercises synthetic missing-core requests through V1 and V2 and checks for the retry trace event. AI assistance was used to investigate the issue and prepare the patch. A human reviewed the exact 33-line diff before submission (SHA-256 `fd289cc9509c40fcdb6442784ba930cf1788c5a70c723e86de5f7734e0ba8b00`); the contributor takes responsibility for the submitted code. # Tests - Passed: `:solr:modules:opentelemetry:test --tests org.apache.solr.opentelemetry.TestDistributedTracing.testV2RetryOnMissingCore -Ptests.seed=1B0EDBEEF6E66854` (1 test; focused only). - `./gradlew tidy updateLicenses check -x test` was attempted. `tidy` and license tasks ran, but the command failed at `:rat` because Gradle reported that `:rat` consumes `:versionCatalogFormat` output without a declared dependency. The full pre-commit check did not pass. - No full test suite or CI status is claimed. # Checklist - [x] I have reviewed the guidelines for [How to Contribute](https://github.com/apache/solr/blob/main/CONTRIBUTING.md) and my code conforms to the standards described there to the best of my ability. - [ ] I have created a Jira issue and added the issue ID to my pull request title. (The pre-existing issue is linked above.) - [ ] I have given Solr maintainers access to contribute to my PR branch. (Optional; not separately enabled.) - [x] I have developed this patch against the `main` branch. - [ ] I have run `./gradlew check`. - [x] I have added tests for my changes. - [ ] I have added documentation for the Reference Guide. - [ ] I have added a changelog entry. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
