[ https://issues.apache.org/jira/browse/SOLR-18587 ]
Nick Shanin deleted comment on SOLR-18587:
------------------------------------
was (Author: JIRAUSER314749):
Root cause, from the matched-pair runs on the RC3 tip ({{749712b71940}}):
# Code: after a failed reload, the previous core can still be loaded.
{{CoreContainer.unloadWithoutCoreOp}} took the "core failed to init" shortcut
and returned without closing it, so the data directory was never cleaned up.
# Test setup: the test asserts the data directory is deleted, but it ran on
{{MockDirectoryFactory}}, which never deletes files. The test needs a
filesystem-backed factory ({{useFactory(null)}}).
Matched pairs, same seed and same test with the test change on both legs: at
seeds {{787C6229591C6F1E}} and {{5A3E9C1D7B2F4808}} the base fails with "data
directory was not cleaned up" and the fixed tree passes. Without the test
change the fixed tree still fails at {{787C6229591C6F1E}}, which is why both
changes are part of the fix.
Fix branch, two commits on the RC3 tip, not a PR:
[solr-18587-coreadmin-unload-failed-reload|https://github.com/nick-boss-tech/solr/tree/solr-18587-coreadmin-unload-failed-reload].
Diff: [compare against the RC3
tip|https://github.com/nick-boss-tech/solr/compare/749712b71940...solr-18587-coreadmin-unload-failed-reload].
The same change is also carried on the RC3 candidate branch named in my
earlier comment.
🤖 _AI text above_ 🤖 _(reviewed by Nick Shanin)_
> CoreAdminHandlerTest.testDeleteInstanceDirAfterCreateFailure fails repeatedly
> in the 10.1.0 RC3 smoke tests
> -----------------------------------------------------------------------------------------------------------
>
> Key: SOLR-18587
> URL: https://issues.apache.org/jira/browse/SOLR-18587
> Project: Solr
> Issue Type: Test
> Reporter: Nick Shanin
> Priority: Major
>
> h2. What was seen
> In five completed runs of the Solr 10.1.0 RC3 smoke tester (artifacts rev
> {{749712b71940c9f96d824c533f32f5c56dcd3924}}, JDK 21.0.12.1, aarch64), the
> build failed every time, and
> {{CoreAdminHandlerTest.testDeleteInstanceDirAfterCreateFailure}} failed in
> all five runs, across different random seeds.
> h2. Caveat
> All five runs were on one small ARM host (4 CPUs, 7 GB), so a host effect is
> not yet separated from a code or test cause. The failure repeats across seeds
> on that host; whether it reproduces elsewhere is part of what this ticket
> tracks.
> h2. Related
> SOLR-9433 covers the SolrCore clean-up path this test exercises. Related RC3
> smoke failures: RecoveryAfterSoftCommitTest is SOLR-18530 (fix in PR #5098)
> and TestCoordinatorRole.testNRTRestart is SOLR-16630 (fix in PR #5106);
> neither fix is in RC3.
> 🤖 _AI text above_ 🤖 _(reviewed by Nick Shanin)_
--
This message was sent by Atlassian Jira
(v10.3.26#10030026)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
