nick-boss-tech commented on PR #5192: URL: https://github.com/apache/solr/pull/5192#issuecomment-6450986593
🤖 *AI text below* 🤖 *(reviewed by Nick Shanin)* @sigram, agreed. [bd42a1d58b9](https://github.com/apache/solr/commit/bd42a1d58b9fba4656a200536a007d9d79dc45b2) adds `ExecutorUtil.ExecutorTerminationTimeoutException`, a `RuntimeException` subtype, and narrows the `CoreContainer.shutdown()` catch to that type. Other runtime exceptions propagate. The timeout message and pool details are unchanged. [Full follow-up diff, including the tidy repair](https://github.com/apache/solr/compare/dd65b21b41dc1d008c51031b71f61964ee2ca169...6ca1cba8061b3c6298040634972afc4361f55add). At tested head `6ca1cba8061b3c6298040634972afc4361f55add`, `ExecutorUtilTest` (6 tests) and `CoreContainerShutdownTest` (1 test) pass on both seeds `18564ABC0001` and `18564ABC0002`. `TestCoreContainer` has 22 passes and 3 expected Windows-only skips per seed. Tidy, Error Prone compilation, and root `check -x test` pass, with `NODE_ENV` unset. Replacing only the typed timeout throw with plain `RuntimeException` makes the strengthened assertion fail with the expected type mismatch; the same test passes at the tested head. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
