epugh commented on PR #5218:
URL: https://github.com/apache/solr/pull/5218#issuecomment-6456554613
Thanks @nick-boss-tech — both points independently verified and addressed,
in `6e14f58`/`26d97fb`:
1. **UI test routing bug**: confirmed by reverting to the pristine commit
and re-running — `testCreateAndDeleteParamsetViaUi` does fail there too, so
this was pre-existing, not something the v2 migration itself introduced test
coverage for. Fixed `paramsetRows()` to use `/config/params/{name}` (the actual
v1 path, unchanged by this migration) with the `response`-wrapped lookup v1
still uses.
2. **v1 compatibility**: agreed this needed an explicit decision rather than
an implicit side effect. Went with preserving v1's existing behavior:
`SolrConfigHandler`'s v1 `handleGET()` now catches the `NOT_FOUND` from
`GetParamSets.getParamSet()` and falls back to the original
200-with-no-`params`-entry shape for an unknown paramset name. v2 keeps its own
404, which is correct per our v2 API conventions (NOT_FOUND for a referenced
resource that doesn't exist).
Worth noting for the record: `TestSolrConfigHandler.testReqParams()`
(parameterized across both v1 and v2 harnesses) had already been updated in
this PR to assert the *new* 404 message for both versions — so the v1 behavior
change was already covered by a test, just not called out in the PR
description/changelog as you flagged. Updated that test to branch on harness
version instead, and updated the changelog to document the split explicitly.
Also included in the same push: the Admin UI's paramsets/query screens now
read through the generated `ParamSetsApi` JS client instead of a hand-rolled
`$resource`, which surfaced two more small bugs (a synchronous throw on an
empty/deselected paramset name, and the same v1-routing mismatch in the UI
test) - both fixed.
Verified with real test runs throughout (not just read-through):
`TestSolrConfigHandler` (8), `GetParamSetsTest` (3),
`AdminUiParamsetsScreenTest` + `AdminUiQueryScreenTest` (7, real Selenium),
`V2ConfigAPIMappingTest` (2) - all passing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
