janhoy commented on code in PR #5248: URL: https://github.com/apache/solr/pull/5248#discussion_r4398233186
########## changelog/unreleased/SOLR-18593-js-client-prod-install.yml: ########## @@ -0,0 +1,12 @@ +# See https://github.com/apache/solr/blob/main/dev-docs/changelog.adoc +title: + The generated JS client's build (solr/webapp/js-client) now installs with --include=dev, so it no + longer fails when the builder's environment has NODE_ENV=production set - npm would otherwise + skip the devDependencies (Babel and its plugins) that the build's own "prepare" script needs. +type: fixed Review Comment: Maybe user "other" for non-product fixes? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
