nick-boss-tech commented on PR #5254: URL: https://github.com/apache/solr/pull/5254#issuecomment-6474453598
🤖 *AI text below* 🤖 *(reviewed by Nick Shanin)* @dsmiley, the production changes in this PR look good to me. I have four additional Gradle unit tests in `TestSolrVersion` if useful: exact range boundaries for prereleases, build metadata and immutability, normalization of released versions, and ordering across patch/minor/major versions. They also assert that `compareTo` and `equals` still distinguish a prerelease from its release after range matching. The [test-only diff from your current head](https://github.com/nick-boss-tech/solr/compare/d59169c9cc96dd60c976079d18ef4da56024bb26...842b1fb426860764d442c87738252b70eccf2c93) changes only `TestSolrVersion.java`. <details> <summary>Linux validation at 842b1fb426: 14 tests passed</summary> Validated at `842b1fb426860764d442c87738252b70eccf2c93` on Linux aarch64, JDK 21.0.12.1+1, Gradle 9.7.0: - `TestSolrVersion`: 12/12 passed, no skips. - `NodeSystemInfoProviderTest`: 2/2 passed, no skips. - Seed: `18432C0DE`. - `./gradlew tidy`: passed, with no changes. - `./gradlew check -x test`: passed. Four one-line mutations failed at their intended assertions: bypassing range normalization, retaining the prerelease, dropping build metadata, and collapsing patch versions. Their executed-test/failure counts were 1/1, 2/2, 2/2 and 1/1 respectively; none failed during compilation or setup. </details> To take these unit tests without rewriting history: ```bash git switch SOLR-18432-solrversion-prerelease git fetch https://github.com/nick-boss-tech/solr.git solr-18432-gradle-only git merge --ff-only 842b1fb426860764d442c87738252b70eccf2c93 ``` I also wrote a BATS test that starts a release-version node, joins a snapshot node, and checks version registration, replication, local reads, and absence of the false older-version warning. I lack Docker, so it remains untested and is on the separate `solr-18432-submit` branch in [b849945c88b](https://github.com/nick-boss-tech/solr/commit/b849945c88bf894d273455882b25d786a8c1e6d1). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
