[
https://issues.apache.org/jira/browse/SOLR-18154?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Smiley updated SOLR-18154:
--------------------------------
Description:
🤖 Goal: when a CREATE collection request returns successfully, the collection
is fully usable. Any client (CloudSolrClient included) can immediately index
and query it, without polling via {{waitForState}} /
{{waitForActiveCollection}}. Our SolrCloud tests nearly always call these after
creating a collection, which hides real issues. Users shouldn't need to do this
either.
This is an umbrella. Linked "Required" issues must be done before we can safely
remove these calls from tests. Expect more to be discovered as test calls are
removed.
h3. Plan
* On *main only*, remove the post-creation waits from the tests in a primary
package first (e.g. the core {{cloud}} test package), then watch it for flaky
failures. Each new failure pattern becomes a linked issue here.
* Once that package has been stable for a while, do a final pass removing the
remaining calls everywhere else.
* Do not backport the test changes until main has been stable for a while.
h3. Known concerns
* CREATE may return before replicas are active (SOLR-17712,
{{waitForFinalState}} defaults to false).
* A client with a stale view may not know the collection exists (SOLR-18606).
* A client may see a collection that is still being built, e.g. replicas not
yet active or no leader yet. Unknown whether stale-state retry handles this
cleanly. File an issue if tests show it.
Out of scope initially: other replica-creating commands (ADDREPLICA,
SPLITSHARD, RESTORE), which have similar issues.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
was:Our SolrCloud tests nearly always call waitForState after collection
creation. This issue seeks a stop to that. It's both a test issue (to
actually remove these calls in tests) but also an umbrella issue pointing to
issues that are required for us to safely remove these calls in tests. This is
actually not just a test issue since we want actual users/clients to not have
to want to wait for a collection to be ready either!
Issue Type: Improvement (was: Test)
Summary: SolrCloud: collection creation should be synchronous (no
waitForState needed) (was: Remove waitForState after collection creation)
> SolrCloud: collection creation should be synchronous (no waitForState needed)
> -----------------------------------------------------------------------------
>
> Key: SOLR-18154
> URL: https://issues.apache.org/jira/browse/SOLR-18154
> Project: Solr
> Issue Type: Improvement
> Components: Tests
> Reporter: David Smiley
> Priority: Major
>
> 🤖 Goal: when a CREATE collection request returns successfully, the collection
> is fully usable. Any client (CloudSolrClient included) can immediately index
> and query it, without polling via {{waitForState}} /
> {{waitForActiveCollection}}. Our SolrCloud tests nearly always call these
> after creating a collection, which hides real issues. Users shouldn't need to
> do this either.
> This is an umbrella. Linked "Required" issues must be done before we can
> safely remove these calls from tests. Expect more to be discovered as test
> calls are removed.
> h3. Plan
> * On *main only*, remove the post-creation waits from the tests in a primary
> package first (e.g. the core {{cloud}} test package), then watch it for flaky
> failures. Each new failure pattern becomes a linked issue here.
> * Once that package has been stable for a while, do a final pass removing the
> remaining calls everywhere else.
> * Do not backport the test changes until main has been stable for a while.
> h3. Known concerns
> * CREATE may return before replicas are active (SOLR-17712,
> {{waitForFinalState}} defaults to false).
> * A client with a stale view may not know the collection exists (SOLR-18606).
> * A client may see a collection that is still being built, e.g. replicas not
> yet active or no leader yet. Unknown whether stale-state retry handles this
> cleanly. File an issue if tests show it.
> Out of scope initially: other replica-creating commands (ADDREPLICA,
> SPLITSHARD, RESTORE), which have similar issues.
> 🤖 Generated with [Claude Code](https://claude.com/claude-code)
--
This message was sent by Atlassian Jira
(v10.3.26#10030026)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
