Copilot commented on code in PR #874: URL: https://github.com/apache/solr-operator/pull/874#discussion_r4407394482
########## docs/modules/upgrade-notes/pages/upgrade-notes.adoc: ########## @@ -143,6 +143,13 @@ Note that Solr `>=9.10` will not start a node older than any Solr node already r * Operator logs now default to `json` encoding at `info` level. Set the new helm value `development` to `true` (CLI flag `--zap-devel`) for the previous `console` encoding at `debug` level. +* The `cp-solr-xml` initContainer has been removed. +The `solr.xml` is now mounted into `/var/solr/data/solr.xml` from the ConfigMap, via a `subPath` volumeMount. +This changes the Solr pod spec, so all Solr pods are restarted when the operator is upgraded. Review Comment: This does not restart clouds configured with `updateStrategy.method: Manual`: their StatefulSet uses `OnDelete`, and the operator only initiates managed rolling updates for `Managed`. Please qualify this statement and tell users of `Manual` to recreate their pods themselves; otherwise they can finish the operator upgrade without applying the new mounts. ########## docs/modules/upgrade-notes/pages/upgrade-notes.adoc: ########## @@ -143,6 +143,13 @@ Note that Solr `>=9.10` will not start a node older than any Solr node already r * Operator logs now default to `json` encoding at `info` level. Set the new helm value `development` to `true` (CLI flag `--zap-devel`) for the previous `console` encoding at `debug` level. +* The `cp-solr-xml` initContainer has been removed. +The `solr.xml` is now mounted into `/var/solr/data/solr.xml` from the ConfigMap, via a `subPath` volumeMount. +This changes the Solr pod spec, so all Solr pods are restarted when the operator is upgraded. +** Sidecars and custom initContainers mounting the data volume no longer find a `solr.xml` in it, it is only mounted into the Solr container. Review Comment: On an existing PVC or retained hostPath, the previously copied `solr.xml` remains on disk; the new mount hides it only inside the Solr container. Sidecars and custom initContainers can still read that copy, but it no longer receives configuration updates. Please document this stale-file case and advise containers needing the current configuration to mount the ConfigMap explicitly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
