janhoy commented on code in PR #5247:
URL: https://github.com/apache/solr/pull/5247#discussion_r4407943248
##########
solr/core/src/test/org/apache/solr/metrics/SolrMetricManagerTest.java:
##########
@@ -293,6 +296,38 @@ public void testMetricExporter() throws Exception {
});
}
+ /**
+ * SOLR-18595: with an exporter registered, each registry gets its own
PeriodicMetricReader, and
+ * every reader reports the SDK's self-telemetry under the same component
id. Merging the
+ * registries the way the metrics endpoint does then saw duplicate label
sets and threw.
+ */
Review Comment:
Agree. The PR is still in draft mode because I have not come around to
reviewing it line by line myself yet.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
