nick-boss-tech commented on PR #5255: URL: https://github.com/apache/solr/pull/5255#issuecomment-6484234349
Hi Amrit, 🤖 *AI text below* 🤖 *(reviewed by Nick Shanin)* I found two follow-up cases while reviewing this and prepared [[fixes and regression tests](https://github.com/nick-boss-tech/solr/compare/1edd6a113b2a9e1b029f509c9279f4fb58683bba...52dacc23b5bb67d254c111c948733da7bc4a9f81)](https://github.com/nick-boss-tech/solr/compare/1edd6a113b2a9e1b029f509c9279f4fb58683bba...52dacc23b5bb67d254c111c948733da7bc4a9f81): - An alias can change while the command waits for its collection lock. The command then resolves it again and can act on a different collection. The fix checks the resolved source against the acquired lock and returns 409 with a retry message if they differ, preserving the original alias for DELETE/RENAME bookkeeping. - In Overseer mode, rejecting a multi-collection alias during lock acquisition stores a string where `SolrResponse.getException()` expects a `NamedList`, turning the intended 400 into a 500. The fix preserves the structured error for synchronous and asynchronous requests. At `52dacc23b5bb67d254c111c948733da7bc4a9f81`, all six focused tests passed on both seeds (`5255C0DE`, `18589C0DE`). The neighboring suites reported 71 tests, no failures or errors, and one inherited `@AwaitsFix(SOLR-13021)` skip. That test, `CollectionsAPISolrJTest.testCreateAndDeleteShard`, passed separately with `-Ptests.awaitsfix=true`. Tidy and `check -x test` passed; the root check ran in a full clone with `NODE_ENV` unset. With the original production code and the new tests, four tests fail and two controls pass. The queued alias-retargeting test fails by timing out waiting for FAILED; it does not record the final async state. The tested head is a fast-forward of this PR’s current head. To take the changes: ```sh git switch alias-lock-key-18589 git fetch https://github.com/nick-boss-tech/solr.git solr-18589-submit git merge --ff-only 52dacc23b5bb67d254c111c948733da7bc4a9f81 ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
