aruggero commented on code in PR #5246:
URL: https://github.com/apache/solr/pull/5246#discussion_r4410991759
##########
solr/core/src/java/org/apache/solr/schema/DenseVectorField.java:
##########
@@ -341,6 +344,30 @@ public void checkSchemaField(final SchemaField field)
throws SolrException {
}
break;
}
+
+ try {
+ // format does not expose any validation, however by constructing
+ // we will run lucene level argument validation
+ buildKnnVectorsFormat();
+ } catch (IllegalArgumentException e) {
+ throw new SolrException(
+ SolrException.ErrorCode.SERVER_ERROR,
+ getClass().getSimpleName()
+ + " "
+ + toSolrParamNames(e.getMessage())
+ + ": "
+ + field.getName(),
+ e);
+ }
+ }
+
+ /** Replaces Lucene's HNSW argument names with the corresponding Solr
parameter names. */
Review Comment:
In that scenario, I'd expect this to be handled as part of the Lucene
upgrade: if Lucene changes this behaviour, whoever upgrades Solr to the new
Lucene version should update the Solr side accordingly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
