[
https://issues.apache.org/jira/browse/SOLR-16398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18134470#comment-18134470
]
Nick Shanin edited comment on SOLR-16398 at 10/29/26, 11:35 PM:
----------------------------------------------------------------
[~gerlowskija] [~epugh] I have the remaining work on this ticket implemented
and tested, on branches against current main:
* Collection commands: Jersey resources for split shard, move replica,
rebalance leaders, and migrate docs, replacing the annotated classes; the
module check passes.
* Core commands: Jersey resources for the CoreAdmin actions, delegating to the
existing handler logic, with a new integration test covering the routes; the
module check passes.
* Reindex collection: a Jersey resource for the reindex command; the reindex
tests pass (7 of 7) and the module check passes.
* Replication commands: the POST commands not yet covered (fetch-index,
abort-fetch, enable-poll, disable-poll, restore, delete-backup) plus the debug
dump endpoint, building on the restore-status, commits, and enable/disable APIs
Jalaz Kumar landed this week and following the same pattern they use;
CoreReplicationAPITest passes (28 tests, 1 skipped on a platform assumption)
and the module check passes.
I am splitting the PRs more finely than one per area, following the sizing
guidance in [~gerlowskija]'s comment on this ticket (one or two APIs per PR).
That makes eleven PRs: the collection commands as two (split shard with move
replica; rebalance leaders with migrate docs); the core commands as four of two
actions each; reindex on its own; and replication as four (fetch-index with
abort-fetch; enable-poll with disable-poll; restore with delete-backup; the
debug dump endpoint on its own). Each will go up as a draft; the draft status
is due to the open-PR limit on my side, and the work is complete and ready for
review. Would you be willing to review them? And if Jalaz Kumar is already
working on any of these and wants to keep going, I am glad to step aside on
those; otherwise I am prepared to submit all eleven.
🤖 _AI text above_ 🤖 _(reviewed by Nick Shanin)_
was (Author: JIRAUSER314749):
[~gerlowskija] [~epugh] I have four slices of this ticket implemented and
tested, each on its own branch against current main:
* Collection commands: Jersey resources for split shard, move replica,
rebalance leaders, and migrate docs, replacing the annotated classes; the
module check passes.
* Core commands: Jersey resources for the CoreAdmin actions, delegating to the
existing handler logic, with a new integration test covering the routes; the
module check passes.
* Reindex collection: a Jersey resource for the reindex command; the reindex
tests pass (7 of 7) and the module check passes.
* Replication commands: the POST commands not yet covered (fetch-index,
abort-fetch, enable-poll, disable-poll, restore, delete-backup) plus the debug
dump endpoint, building on the restore-status, commits, and enable/disable APIs
Jalaz Kumar landed this week; CoreReplicationAPITest passes (18 tests, 1
skipped on a platform assumption) and the module check passes.
Each slice has its own changelog fragment and is independent of the others. My
plan was to open one PR per slice, each as a draft; the draft status is due to
the open-PR limit on my side, and the work is complete and ready for review.
Would you rather see the four slices as separate PRs, or grouped differently?
And would you be willing to review them?
🤖 _AI text above_ 🤖 _(reviewed by Nick Shanin)_
> Cosmetic improvements and migration to JAX-RS (miscellaneous coll/core APIs)
> ----------------------------------------------------------------------------
>
> Key: SOLR-16398
> URL: https://issues.apache.org/jira/browse/SOLR-16398
> Project: Solr
> Issue Type: Sub-task
> Components: v2 API
> Affects Versions: 10.0
> Reporter: Jason Gerlowski
> Priority: Major
> Labels: newdev, pull-request-available
> Time Spent: 8h 10m
> Remaining Estimate: 0h
>
> As mentioned on SOLR-15781, the v2 API currently has an experimental
> designation, and the community has expressed an interest in using this period
> to update our v2 endpoints to be more REST-ful and consistent. The current
> plan is to follow the specific changes laid out in [this
> spreadsheet|https://docs.google.com/spreadsheets/d/1HAoBBFPpSiT8mJmgNZKkZAPwfCfPvlc08m5jz3fQBpA/edit?usp=sharing],
> though of course nothing there is set in stone and there are still warts to
> be worked out.
> While we're touching the code for these endpoints, we should also convert
> them to JAX-RS framework definitions. (This was initially tracked as a
> separate effort - see SOLR-16370 - but the edit that were required ended up
> overlapping so significantly with the "cosmetic" improvements here that in
> practice it almost always makes sense to do the two together.)
> This ticket plans to tackle making the changes required for any APIs not
> covered by any other SOLR-15781 subtask.
> Some helpful links related to these changes these changes. Should help get
> any interested newcomers started!
> * For detailed information on Solr's current and desired v2 APIs see the
> spreadsheet
> [here|https://docs.google.com/spreadsheets/d/1HAoBBFPpSiT8mJmgNZKkZAPwfCfPvlc08m5jz3fQBpA/edit?usp=sharing]
> * [Discussion of how APIs work in Solr
> (video)|https://www.youtube.com/watch?v=iIpvfXBjDog]
> * [Step-by-step guide to creating
> APIs|https://issues.apache.org/jira/browse/SOLR-15737?focusedCommentId=17617923&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17617923]
> using the JAX-RS v2 API framework
> * [Example PR for a similar change|https://github.com/apache/solr/pull/1679]
--
This message was sent by Atlassian Jira
(v10.3.26#10030026)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
