SpookyJumpyBeans commented on PR #5253: URL: https://github.com/apache/solr/pull/5253#issuecomment-6512798261
Thanks for the detailed review. You're right, dropping the buffer and removing the whole rule assumes this MIGRATE owns both, and it doesn't (rules merge per route key, and the buffer is shared by every forwarding stream, recovery and split). Async step failures also don't abort MIGRATE today. I've moved this to draft. A correct fix seems to need ownership of the buffering and stricter failure handling, so I'd like maintainers' input on the intended contract for a failed MIGRATE before I rework it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
