dsmiley commented on code in PR #5268:
URL: https://github.com/apache/solr/pull/5268#discussion_r4430296461
##########
gradle/solr/solr-ui.gradle:
##########
@@ -133,6 +137,16 @@ tasks.register('buildUiFromSource') {
inputs.dir(file("$rootDir/ui/shared/src"))
inputs.dir(file("$rootDir/ui/webApp/src"))
outputs.dir(uiFromSourceOutputDir)
+ doFirst {
+ // The source build resolves Compose Desktop's per-platform native
libraries, which have no
+ // s390x variant. The published wasm artifact is platform independent, so
use that instead.
+ if ("s390x".equalsIgnoreCase(System.getProperty("os.arch"))) {
+ throw new GradleException(
+ "Building the Admin UI from source is not supported on s390x; " +
+ "drop -Psolr.ui.buildFromSource=true to use the published
artifact."
+ )
+ }
Review Comment:
> The published wasm artifact is platform independent, so use that instead.
I'm confused; how does this change result in "use that instead" for s390x?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
