dsmiley commented on code in PR #5212: URL: https://github.com/apache/solr/pull/5212#discussion_r4437558049
########## changelog/unreleased/contributing-slack-link.yml: ########## Review Comment: Tell me first: do you agree with my assertion? This was an easy call for me. Your response wasn't clear either way and thus I can't tell if we have a deeper disagreement of changelog worthiness or if we're aligned on that front and merely find compliance too hard. Sorry but I _very_ much dislike your proposals: > What do you tihnk about having your backport script decide this? -1 That's totally the wrong time to make that determination. Someone may have wasted their time writing one and _littering_ the file on main. > Or just have everything have a changelog, - 1 OMG no; many smaller changes don't deserve the bookkeeping hassle. That said, I think it'd be fine to remove any that were added that "should not" (subjectively)... I think what we need is an LLM powered GHA workflow bot that can make a recommendation. And it's merely a bot recommendation, not a replacement for human judgement. This would *replace*/update the existing GHA workflow that nags us for a changelog (often times not needed; I dislike this bot very much in its current form). Perhaps the llm.apache.org service could be of use... CC @janhoy (this very much should have been a dev list rhead admittedly) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
