nick-boss-tech commented on PR #5281: URL: https://github.com/apache/solr/pull/5281#issuecomment-6613016989
🤖 *AI text below* 🤖 *(reviewed by Nick Shanin)* @dsmiley I put together a follow-up on top of your current head: [changes from `3597068` to `6bcaa9e`](https://github.com/nick-boss-tech/solr/compare/35970681650b4e602632bdfc344c5922b9f1581f...6bcaa9e1191fb8d0c6def2eaf005b602bf882e40). It implements the suggestions in your comments: an early warning for PRs targeting something other than `main`, an optional maintainer-edit reminder that accounts for organisation-owned forks, and an advisory Jira judgement in place of the corresponding template checkboxes. The Jira comparison checks for a title reference; it does not verify the issue itself. I also fixed three cases in the helper: deleted files counted as included evidence, missing or malformed model answers became “no,” and model reasons could render active Markdown/HTML. The follow-up reports unknown answers explicitly and renders reasons as text. It uses the trusted workflow revision for executable code, installs PyYAML explicitly, and rejects changed or incomplete API snapshots. It adds 23 offline tests and a separate test workflow with no secrets or write permissions. Verified on Linux: all 23 tests pass. Three regressions fail against the original helper and pass with the fixes. GFM rendering checks and actionlint with ShellCheck pass; `./gradlew tidy` leaves the tree clean, and `./gradlew check -x test` passes. The root check passed from a real clone after Antora rejected the worktree's `.git` file. You can pull the tested commit into your PR branch with: ```sh git switch pr-triage-llm git fetch https://github.com/nick-boss-tech/solr.git pr-5281-triage-followup git merge --ff-only 6bcaa9e1191fb8d0c6def2eaf005b602bf882e40 ``` Live ASF gateway behavior and GitHub activation, including secret setup, event delivery, notifications and comment publication, still need a controlled smoke test once the workflow is available from the trusted branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
