nick-boss-tech commented on PR #5282: URL: https://github.com/apache/solr/pull/5282#issuecomment-6620286899
🤖 AI text below 🤖 (reviewed by Nick Shanin) Thanks, Eric. I understand the concern about the test setup. JavascriptExecutor is already used in [AdminUiSqlScreenTest](https://github.com/apache/solr/blob/82954b9df687d8239c4344b292b3afff5005f898/solr/webapp/src/test/org/apache/solr/webapp/AdminUiSqlScreenTest.java#L83). Here it controls callback order so the tests can deliver an old response after a newer navigation while exercising the bundled Angular/Chosen code. I’d prefer to retain that coverage if it proves reliable in CI, but I’m happy to remove the test afterward if you feel the maintenance cost outweighs its value. On menuGeneration: yes, it advances on route changes and explicit menu refreshes, with no periodic timer incrementing it. Reaching JavaScript’s integer precision limit would require an infeasible number of refreshes during one browser session. I fixed the CI error but I did not run Selenium. Could you trigger it again please? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
