Copilot commented on code in PR #879: URL: https://github.com/apache/solr-operator/pull/879#discussion_r4466594646
########## docs/modules/solr-prometheus-exporter/pages/index.adoc: ########## @@ -36,7 +36,9 @@ You have two options for the prometheus exporter to find the zookeeper connectio * Provide the name of a `SolrCloud` object in the same Kubernetes cluster, and optional namespace. The Solr Operator will keep the ZK Connection info up to date from the SolrCloud object. -This name can be provided at: `SolrPrometheusExporter.spec.solrRef.cloud.name` +This name can be provided at: `SolrPrometheusExporter.spec.solrRef.cloud.name`, and the namespace at: `SolrPrometheusExporter.spec.solrRef.cloud.namespace` Review Comment: The newly documented namespace path uses `spec.solrRef`, but the API type and CRD expose `spec.solrReference` (`api/v1beta1/solrprometheusexporter_types.go:32`). Configuring `spec.solrRef.cloud.namespace` therefore will not set the referenced namespace. Please use `SolrPrometheusExporter.spec.solrReference.cloud.namespace` and correct the name path on this line as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
